March 2005 - Development - lists.drupal.org

Re: [drupal-devel] forum.module dependent on comment.module
by Boris Mann 05 Mar '05

05 Mar '05

On Fri, 4 Mar 2005 14:18:21 -0500, Chris Cook <beerfan(a)gmail.com> wrote: > On Fri, 04 Mar 2005 09:38:12 -0500, Moshe Weitzman > <weitzman(a)tejasa.com> wrote: > > I don't see any value in a forum that disallows comments. > > I think a better long term goal, for forum.module, is to eliminate > dependance on comments altogether. When trying to integrate > mailhandler and listhandler so that listserve messages are added as > forum nodes it feels very strange and inappropriate to add some > messages as nodes and others as comments. When I was working on this > it seemed like there was more of a reason it should not be done but I > don't remember now. Hmm. Well, this is a bit like we discussed at DrupalCon about how forum is nothing more than threaded display of nodes. But, to be clear, having nodes as topic replies is very, very different from what we have now. In fact, we would have to implement threading output just for this, and also store next/prev links, much like book. Actually...it's identical to book hierarchy, except for a different display... But that's very much a hand-waving, Forum Next Generation type discussion. For now, forum responses are comments, so forum requires comments module. I *have* run sites with comments off everywhere but in forums. -- Boris Mann http://www.bryght.com

4 3

[drupal-devel] Update .POT files?
by Dries Buytaert 05 Mar '05

05 Mar '05

Could either Goba or Gerhard update the core .POT files as time permits? Like that, translators could start updating their translations (and eventually create a DRUPAL-4-6 branch for their translations). Once updated, please add a note or section about it to the Drupal 4.6.0-RC announcement. (Only a fraction of the translators are on this mailing list.) -- Dries Buytaert :: http://www.buytaert.net/

2 2

[drupal-devel] Drupal 4.6.0 release candidate
by Dries Buytaert 05 Mar '05

05 Mar '05

The Drupal 4.6.0 release candidate is available! Details at: http://drupal.org/drupal-4.6.0-rc Traditionally, this implies an increased amount of bug reports and support issues. Therefore, all Drupal contributors are encouraged to focus on the pending bugs, documentation and support requests. -- Dries Buytaert :: http://www.buytaert.net/

2 2

[drupal-devel] Release management: DRUPAL-4-6 tag created
by Dries Buytaert 05 Mar '05

05 Mar '05

The DRUPAL-4-6 tag is now available. As such, maintainers of themes and modules can branch their code as soon it is tested to work with Drupal 4.6. More information is available at http://drupal.org/node/7765. Note that Drupal core has _not_ been branched yet. It will be branched when (i) Drupal 4.6.0 is considered to be stable enough (almost ready) and when (ii) one or more bigger patches are queued for inclusion. -- Dries Buytaert :: http://www.buytaert.net/

1 0

[drupal-devel] [bug] node_access_where_sql changed behaviour
by chx 05 Mar '05

05 Mar '05

Issue status update for http://drupal.org/node/18418 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/node_access_inter_name.patch (1.21 KB) jonbob node_access_view_all patch changed the return value of node_access_where_sql to empty which breaks nicely all queries which are still using this function. This is a good incentive to upgrade to db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not really trivial why the query suddenly not works. Let's make it trivial -- rename it _node_access_where_sql, it is no longer a function to be called from outside. node_access_join_sql similarly. chx

1 0

[drupal-devel] [bug] node_page issues
by killes 05 Mar '05

05 Mar '05

Issue status update for http://drupal.org/node/18406 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/node-edit.patch (1.4 KB) node_page should have gotten some love over the last couple of release cycles. Is still uses a major switch statement in one huge function instead of multiple small functions. It also allows some funny pages like node/n/edit to be seen. Does leave a bad impression. killes(a)www.drop.org

1 0

[drupal-devel] [bug] Reference to auto generated primary links
by killes 05 Mar '05

05 Mar '05

Issue status update for http://drupal.org/node/18404 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/system_4.patch (1.21 KB) This reference should be removed, it is untrue. killes(a)www.drop.org

1 0

[drupal-devel] Issue spam
by Chris Cook 04 Mar '05

04 Mar '05

It looks like the project issues are receiving spam. http://drupal.org/node/14710

1 0

[drupal-devel] forum.module dependent on comment.module
by Negyesi Karoly 04 Mar '05

04 Mar '05

Hi! forum.module is dependent on comment.module in a very visible way on this line: $topic->new_replies = comment_num_new($topic->nid, $history); and in subtle ways, by SELECTing from node_comment_statistics which is INSERTed and UPDATEd in comment_nodeapi. First of all, this at least needs to be documented and also we need to describe how to have a site where users can not comment but can use forums. Second, we shall either change forum not be dependent on comment or we shall make a mechanism which makes sure that if forum is enabled then comment is enabled also. I do know that this could delay 4.6 but this is very confusing and there are several threads already on drupal.org about it. Regards NK

4 5

[drupal-devel] [task] Extra style in Drupal.css
by drumm 04 Mar '05

04 Mar '05

Issue status update for http://drupal.org/node/18380 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: minor Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/drupal.css_0.diff (439 bytes) Putting margins on paragraph tags seems like something that Drupal.css shouldn't be doing. drumm

1 0