May 2006 - Development - lists.drupal.org

4.7 maintenance: Release of Drupal 4.7.1
by Gerhard Killesreiter 20 May '06

20 May '06

Hi there! Since there was a rather bad bug in the update system I plan to release Drupal 4.7.1 early next week. So I'd like you all to help me by creating and testing patches against the Drupal 4.7 branch. Please remember that only bug fixes will be accepted, so don't waste your tme with new features. Cheers, Gerhard

5 7

hook_view() is called before hook_nodeapi()
by Dmitry Gukov 20 May '06

20 May '06

Hello, everybody! I faced this problem when developing signature.module. The module appends user's signature dynamically nodes and comments. So, I think a signature should be added to the end of a body. The problem is at least with forum.module, which adds "next-topic-link" before a signature. (This is not OK to have signature after "next-topic-link".). This is because hook_view() is called before hook_nodeapi(). Normally, if "next-topic-link" was in hook_nodeapi, I could decrease my module's weight, so it would fix it. But it's in hook_view. The solution I found is to add signature at hook_hodeapi(when $op == 'view'), but then of course, signature is added to the body when editing the node, what is not good since it is already added dynamically. I can remove it when $op == 'preprocessing', but it's a 'dirty fix'. And please let me know what you think about my variant. May be someone can suggest a better implementation? P.S. I posted it here, because I believe it's a question for 'gurus'. Dmitry

1 0

#just_before_validation ?
by Bèr Kessels 20 May '06

20 May '06

Hi, I am looking for the following: I want to generate the title of a node from content in that node. Hence I need to hook into the node submission on several places. First: hook_form_alter, to make the title field hidden Then just *before* validation to capture the node content and fill a title. So that all possible validation hooks can still run, but that the title has a value. Any idea what kind of hook, or #callback I should be looking at? #validate is not a good option, since I think it is important to run all the normal validations on that title field. But maybe the trick is to set that #validate, and inside that callback function fill the title value and then call all the validation hooks from there? I am personally not a fan of using validation to cahnge values. Validation is for.... validation. Also important is, that this needs a POST, because I have to grab info from that POSTed node. Bèr -- [ End user Drupal services and hosting | Sympal.nl ] CVS onder de knie krijgen: http://help.sympal.nl/cvs_onder_de_knie_krijgen

1 0

Autocomplete For A "Select" Widget
by Rob Thorne 20 May '06

20 May '06

I'm looking at using autocomplete for contacts stored in CiviCRM. Implementing basic autocomplete using the standard Drupal hook was pretty simple: just search the CRM store for a contacts "display name" via the autocomplete handler. But there's a problem with how the standard handler works: display names are not unique. What I probably *need* to do is this: use the autocomplete field to populate a "select" widget that uses the display name as the label, and the unique numerical contact_id as the key. Before I start looking into implementing this myself: have any of you implemented this kind of widget? Or do you have advice how best to do this? Thanks, Rob Rob Thorne Torenware Networks http://www.torenware.com

3 2

when we run out of characters
by Karoly Negyesi 20 May '06

20 May '06

Hi! We have a namespace problem. As PHP identifiers can have only letters, numbers and underscores we are using underscores for the hook identifier, ie. we have a hook_menu etc. On the other hand, when a module is best described with more than one word, the words are separated by underscores. This can lead to clashes, like foo.module defines a function called foo_bar_that and when foo_bar.module would like to implement the newly introduced hook_that.... then we have a problem. This already means that if you have a foo.module then you are better not using any function that's called foo_X_hookname. We discussed several solutions on IRC. One of them is using double underscores somewhere. But where? If you use them as hook identifiers you have 35K LoC in core to look through (and change a significant percentage). It will be fun, fun, fun! It's visually very confusing to rename taxonomy_menu to taxonomy__menu because then the hook_menu will look like taxonomy__menu_menu and the two menus look as if they belong together. So, that won't work. Another solution is to use zero underscores somewhere. But where? Again, changing core is not a good option, and I won't like hookmenu instead of hook_menu. So, with perfect logic we arrived to a very ugly point: we shall rename axonomy_menu to taxonomyMenu . Do I like this? _No_! But... Regards NK

19 41

OT: Drupal user and contributor 'alaa' has been arrested
by Karthik 19 May '06

19 May '06

Possibly stale news to some, but alaa [1] was arrested [2] [3][4] a few days ago. Perhaps drupal.org can help out with a (front-page?) story to drum up some support and exposure? -K [1] http://drupal.org/user/8991/ [2] http://www.manalaa.net/ [3] http://politics.slashdot.org/article.pl?sid=06/05/08/1054237 [4] http://news.google.com/news?hl=en&ned=us&q=alaa&btnG=Search+News

9 15

Bug in HTTPGet/HTTPPost?
by Justin 19 May '06

19 May '06

Greetings! I'm working with the vote_up_down module and think that I may have found a bug in HTTPGet()/HTTPPost() functions. A simplified version of the code that is common to both functions: <code> xmlHttp.open('GET', uri, bAsync); xmlHttp.send(null); xmlHttp.onreadystatechange = function() { if (xmlHttp.readyState == 4) { callbackFunction(xmlHttp.responseText, xmlHttp, callbackParameter); } } </code> The idea is that the onreadystatechange handler will allow a callback function to be called asynchronously once the xmlHttp object is in state 4, "completed". However, I believe it is possible that the xmlHttp object sometimes has already transistioned to state 4 before the code that sets the handler is executed. This would mean that the callback is never called because the state never changes (if it is already at "completed"). Reading the MS docs, I learned that it is the send() method which will update the ready state, and so the handler should be set between the open() and send() calls. Like so: <code> xmlHttp.open('GET', uri, bAsync); xmlHttp.onreadystatechange = function() { if (xmlHttp.readyState == 4) { callbackFunction(xmlHttp.responseText, xmlHttp, callbackParameter); } } xmlHttp.send(null); </code> If there is no disagreement, I'd be happy to submit a patch for this change. Cheers, Justin

4 3

RE: [development] RFC: Candidate 'premium' modules
by Steven Peck 19 May '06

19 May '06

> -----Original Message----- > From: development-bounces(a)drupal.org > [mailto:development-bounces@drupal.org] On Behalf Of Dries Buytaert > Sent: Tuesday, May 16, 2006 1:59 AM > To: development(a)drupal.org > Subject: Re: [development] RFC: Candidate 'premium' modules > > On 16 May 2006, at 10:49, Adrian Rossouw wrote: > > Didn't we add 'report back' functionality recently. > > Exactly. Any Drupal 4.7 site can be configured to 'call home' and > report back a list of the enabled themes and modules. Like that, we > can see what modules are actually being used (rather than just being > downloaded). By combining this information with download > statistics, > we can get a pretty good idea of what (i) the popular modules > are and > (ii) what modules are known to work with Drupal 4.7. This > eliminates > guessing, and most of all, the endless discussions inherent to that. > > -- > Dries Buytaert :: http://www.buytaert.net/ > I knew about this feature but not much about it or how it is being used, if it is at this point. I think it needs someone to do a better write up then we have now (none that I have seen) and perhaps how it is or will be used. -sp

1 0

RE: [development] OT: Google Tool Kit allows AJAX development in Java
by Boerland, Bert 18 May '06

18 May '06

-----Original Message----- From: development-bounces(a)drupal.org > It will have to wait till after the Droopal port to Java. No! No! It must be called "ADC (A Drupal of Coffee)" http://drupal.org/node/14784#comment-24090

12 13

Want to merge free tagging & list forms for terms.
by Doq Doques 18 May '06

18 May '06

Hi! Currently developing module called "label". It povides per-user term access. Label vocabularies can be used e.g. for personal nodes categorization, for private message nodes etc. The problem is that I want to allow user to enter new labels (terms) using both list & free tagging fields. Taxonomy allows me to have free-tagging or (not and) normal vocabularies. I have decided to edit taxonomy module to support both of them. The problem is that form elements are constructed in such a way: $form['taxonomy']['tags'][$vocabulary->vid] = array('#type' => 'textfield', $form['taxonomy'][$vocabulary->vid] = taxonomy_form($vocabulary->vid, array_keys($default_terms), $vocabulary->help); so weights will be applied and I will receive all normal vocabularies upper all free-tagging vocabularies. Have tried to use form_render for $form['taxonomy']['tags'][$vocabulary->vid] and $form['taxonomy'][$vocabulary->vid] and then making $form['taxonomy_data'] = array( '#type' => 'markup', '#value' => $curr_form, '#tree' => TRUE, of them, but it doesn't work correctly. Any help? Maybe some better approach?

1 0