November 2007 - Development - lists.drupal.org

Early Drupal 6 review from Chris Messina
by Dries Buytaert 16 Nov '07

16 Nov '07

Hello all, I asked Chris Messina (http://factoryjoe.com/blog/) to fiddle with Drupal 6 and to share his thoughts: http://factoryjoe.pbwiki.com/FeedbackForDrupal6 He has lots of good feedback so I encourage you to _bookmark_ that page. Some of his suggestions we might still be able to incorporate! I also invite you to ask others to write similar write-ups. They are invaluable. Thanks, -- Dries Buytaert :: http://www.buytaert.net/

32 69

hosting solution for Drupalcon videos
by Robert Garrigós Castro 16 Nov '07

16 Nov '07

16 24

create nodes with attached files using drupal_execute
by Isaac Simon Hodes 16 Nov '07

16 Nov '07

Hello, I'm new to the forms API and hoping for some advice. I am creating a multistep form in 5.3. The form uses drupal_execute to generate new CCK nodes. The basic form is working, but I cannot figure out how to make drupal_execute attach files to the new nodes as it creates them. I would like to simply pass a form value to the CCK node form (through drupal_execute) along with the other necessary fields. E.g. something along the lines of $values['file']['field_object_file_upload'][0] = $form_values['my_form_file_upload_field']; Solutions involving either upload module or a CCK file field would be fine. Does anyone have advice? (I hope this is an appropriate question for the "development" list. Based on the descriptions at lists.drupal.org that seems to be the case; if not, please let me know where I should post it.) Thanks for your help!

4 3

Patch for drupal 5.2
by Mo DeJong 16 Nov '07

16 Nov '07

Hello Here is a quick patch to avoid an warning message with drupal 5.2 and Postgres: P.S. I tried to submit a bug report but all the links I could find were broken: http://lists.drupal.org/listinfo/development (link "bug tracker <http://www.drupal.org/project/drupal/issues>" is broken) http://drupal.org/support (link "submit a bug report <http://drupal.org/node/add/project_issue?project=drupal&category=bug>" goes to page with nothing on it) cheers Mo *diff -ur clean_drupal-5.2/includes/install.pgsql.inc drupal-5.2/includes/install.pgsql.inc --- clean_drupal-5.2/includes/install.pgsql.inc Wed Dec 27 05:02:34 2006 +++ drupal-5.2/includes/install.pgsql.inc Thu Nov 15 15:56:08 2007 @@ -93,7 +93,7 @@ // Test UNLOCK, which is done automatically upon transaction end in PostgreSQL $query = 'COMMIT'; $result = pg_query($connection, $query); - if ($error = pg_result_error()) { + if ($error = pg_result_error($result)) { drupal_set_message(st('We were unable to unlock a test table on your PostgreSQL database server. We tried unlocking a table with the command %query and PostgreSQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); $err = TRUE; } @@ -104,7 +104,7 @@ // Test DELETE. $query = 'DELETE FROM drupal_install_test'; $result = pg_query($connection, $query); - if ($error = pg_result_error()) { + if ($error = pg_result_error($result)) { drupal_set_message(st('We were unable to delete a value from a test table on your PostgreSQL database server. We tried deleting a value with the command %query and PostgreSQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); $err = TRUE; } @@ -115,7 +115,7 @@ // Test DROP. $query = 'DROP TABLE drupal_install_test'; $result = pg_query($connection, $query); - if ($error = pg_result_error()) { + if ($error = pg_result_error($result)) { drupal_set_message(st('We were unable to drop a test table from your PostgreSQL database server. We tried dropping a table with the command %query and PostgreSQL reported the following error %error.', array('%query' => $query, '%error' => $error)), 'error'); $err = TRUE; }*

3 2

drupal, ie6 and ssl
by fago 15 Nov '07

15 Nov '07

I wondered if a lot of people are securing their drupal install with SSL? I just stumbled over a annoying bug which occurs if one uploads a file with IE6: http://drupal.org/node/192157 I'm posting this to the list, because I think that this issue is relevant for most people providing secure access for their users. So they should be aware of it. regards, fago

1 0

Taxonomy labeling changes
by Neil Drumm 15 Nov '07

15 Nov '07

Here is how to get this accomplished: 1. Design 2-3 new well-thought-out naming schemes. 2. Test each, and our current system, with 5 users. Chose users with various skill levels and various backgrounds in other software. 3. Objectively see what is best instead of subjectively speculating. Let me know when you have a well-written usability report and I will write the patches. -- Neil Drumm http://delocalizedham.com

5 5

Re: [development] Taxonomy labeling changes
by Liza Sabater 15 Nov '07

15 Nov '07

Money Quote : >It would be nice to reconcile > everything, but changing a core module name, and breaking a chunk of > contributions, is harder than changing the UI label. I hope that in a near future all of the good all technology wordiness is "invisible" at the level of the end-user interface. So focusing on UI hopefully will bring better ways for "masking" the complexity. / liza -- Liza Sabater, Publisher culturekitchen.com dailygotham.com AIM cultkitdiva MOB 646.552.7365 --------- Original Message -------- From: development(a)drupal.org To: development(a)drupal.org <development(a)drupal.org> Subject: Re: [development] Taxonomy labeling changes Date: 14/11/07 10:09 > On Nov 14, 2007 12:27 PM, Michelle Cox <mcox(a)charter.net> wrote: > > On 11/14/2007 2:09:58 PM, Neil Drumm (drumm(a)delocalizedham.com) wrote: > > >Avoid use of "Taxonomy" in the UI. The overall system, despite the > > >module name, is "Categories." > > > > I took a quick peek on my site and the only place I see it called > > "Categories" is on the menu label and the title of this page: > > ?=admin/content/taxonomy . Note the URL to that page. Seems to me like the > > overall system is "Taxonomy" with a half attempt to change it to > > "Categories" that failed. What's wrong with rolling it back while we think > > about what best to call it in 7? > > And the heading of the fieldset on node/add/{content type with more > than one vocabulary}. The name of the overall system simply is not > used a whole lot. This naming system applies for Drupal 4.5 through 5, > and may be changed for Drupal 6. > > We have quite a few precedents for using different labels in UI from > what we use in the API or URLs: > - node is content > - path is URL alias > - watchdog is log > These differences happen and are okay. It would be nice to reconcile > everything, but changing a core module name, and breaking a chunk of > contributions, is harder than changing the UI label. > > -- > Neil Drumm > http://delocalizedham.com > > ________________________________________________ Message sent using UebiMiau 2.7.10

1 0

Re: [development] Do not let postgresql hold back great patches
by Larry Garfield 15 Nov '07

15 Nov '07

On Mon, 12 Nov 2007 08:29:34 -0500, Earnie Boyd <earnie(a)users.sourceforge.net> wrote: >> Amen brother. I am happy which simply removes LOWER from those >> queries and kicks the ball to the postgresql half of the playground. >> As I stated on my blog I have nothing against posgresql just I do not >> want to deal / held back with it. Any support for this solution? >> > > IMO, we need to focus on Drupal SQL[1] and not MySql SQL or Postgresql > SQL or Oracle SQL for coding purposes. Another layer of abstraction > handles the nitty gritty of each different DB. AFAIR, the code prior > to 6 was both MySql and PgSql friendly. So making a change in a > different direction for Drupal 6 doesn't seem TRT to me. However if > Drupal 5 wasn't as PgSql friendly as I remember then I agree with > Karoly. For Drupal 7 I would like to see Drupal SQL handle all of the > syntax changes needed for various DB engines; that means no more > testing of $db_type outside of the Drupal SQL abstraction. Then a > company with Oracle, Sybase and DB2 could display data from all three > database types comfortably with Drupal. > > [1] http://drupal.org/node/191486 You have just proposed that we create our own serialized language called DSQL that we then regex for *every single query* and then rewrite a query for each database backend according to some abstract set of rules. No. That is way too complex and way too slow, especially when it would involve slowing down MySQL (95%) users purely for the sake of everyone else (5% at most). It is also a sign that the architecture is bad: If you serialize a data structure and then string-parse the serialized version, you are doing something wrong. You should have parsed it first, then serialized. The only alternative I see is to use data-structure-based query builders instead in some cases. We do that now for DDL statements (Schema API). I'm planning to do that for all insert/update/delete statements in Drupal 7, and I'm pondering how feasible it would be to require certain types of SELECT queries to use one. I'm still undecided. That is, however, beside the point for right now. Right now, the point is that we're holding back a performance improvement under MySQL and a way to increase the number of shared hosts Drupal runs on (those that don't allow temp tables) for the sake of PostgreSQL, which few shared hosts support anyway. While I agree that forcing us to think about multiple databases is good architecturally, we just don't have the resources to support non-MySQL as well as we do PostgreSQL. I would not object to committing the MySQL portions and fixing PostgreSQL later. --Larry Garfield

6 5

Re: [development] Taxonomy labeling changes
by Michelle Cox 14 Nov '07

14 Nov '07

On 11/14/2007 2:09:58 PM, Neil Drumm (drumm(a)delocalizedham.com) wrote: >Avoid use of "Taxonomy" in the UI. The overall system, despite the >module name, is "Categories." I took a quick peek on my site and the only place I see it called "Categories" is on the menu label and the title of this page: ?=admin/content/taxonomy . Note the URL to that page. Seems to me like the overall system is "Taxonomy" with a half attempt to change it to "Categories" that failed. What's wrong with rolling it back while we think about what best to call it in 7? Michelle

5 4

Wordpress2drupal themes. Questions, Ideas and a broken presentation layer
by TheClue 14 Nov '07

14 Nov '07

Hello to all! :-) Today i surprised myself thinking about how to use the HUGE themes base of WordPress blog platform in our beloved drupal. It's not trivial if u straight convert the CSS and you edit a bit the usual page.tpl.php, block.tpl.php and so, but it's not what i have in mind. My idea is to have the exactly same look of a wordpress site/ theme only replacing WP-API function calls (so that would be very easy to make a wrapper or a wp- engine around phptemplate?). It means that, since i strickly won't change style.css that the html output of various pages MUST be exactly the same A WP layout is more or less a reduced version of a drupal one (limited to two to three regions). For those unfamiliar with WP, newest themes already use the widget paradigm that is very similar to drupal's blocks. But since the layout possibilities of WP are slighty limited, designers very often still hardcode something in theme pages (usually categories list, recent posts and 'meta' items). That's held the problem (remember my needs: 1. same XHTML code 2. CSS unchangable 3. no need to make custom php blocks after installation) 1. I would edit box.tpl.php to provide the same html of a WP's widget, since it is a standard API output. I would override some themeable functions for the content (ie. theme_item_list) accordingly. 2. Because of the WP-theme engine realy limited, VERY VERY often WP designers hardcodes something in the page, usually "meta" informations, categories listing and recent blog posts. You can imagine that these hardcoded menus could have infinite HTML code. This means i cannot use a block model again (I already used it to make the "frame" of widgets). Even because i want a smooth migration, i decided (for now) to hardcode too and i coded a bounce of phptemplate_wpsomething() in my template.php page to keep my .tpl.php pages clear. *** THE PROBLEM *** My template.php is full of overridden functions that are not part of presentation layer! For example. To have a recent blog posts (very common in many WP themes) i had to override the blog module's hook function blog_block because it makes a call to node_title_list() (NOT themeable). And node_title_list() makes a call to theme_item_list that i ALREADY overriden to make code for the widget-blocks! So since node_title_list is not themeable (and it wouldn't be wise to override even if it was) i had to copy-paste the entire hook function in template.php just to make the code for node_title_list inline and, finally, be able to change the call from theme_item_list to theme_somethingelse_item_list! Results: 1. It breaks the presentation layer 2. It is a stupid mess 3. It is very annoying if u have to override lot of functions (WP API is limited but not so limited!) Since I would like to think about an automatic way to convert themes from WP format to Drupal's, I prefer to resolve this issue before proceding. Any idea? :) gabrio PS sorry if my following questions will be stupid or full of grammar errors. I'm a newbie in development and my english is not so great :/

4 4