March 2006 - Development - lists.drupal.org

Hmm how to solve this nicely?
by piotr＠mallorn.ii.uj.edu.pl 10 Mar '06

10 Mar '06

Hi, I have a problem with a bug. It needs a general solution. The problem lies in error_handler() function. Sometimes it needs to do "additional" stuff before doing insert into watchdog. Generally it looks like this: ... some queries here ... 1. now a query that goes bad. This issues error_handler() 2. error handler does INSERT INTO {watchdog} ... control goes back to the place when the error happened Sometimes between 1. and 2. extra actions need to be performed. That is, you can not do the INSERT right away. For example, in http://drupal.org/node/39460 you need to do ROLLBACK. In http://drupal.org/node/53420 you need to do pg_end_copy(). In theory you might have to do both pg_end_copy() and ROLLBACK. But there is at least one extra problem. User can call error handler by himself with trigger_error(). The error handler can spawned by PHP error. In those two cases, we should not do the ROLLBACK. How to differentiate between those two cases and "legitimate" case when we should do some action? Is it possibile at all? How to write it cleanly? -- Piotrek irc: #debian.pl Mors Drosophilis melanogastribus!

1 0

Re: 18 critical bugs left
by qomo 10 Mar '06

10 Mar '06

Karoly et al, Karoly, thanks for writing down your criteria for critical bugs. Dries wrote that we are up to 18 critical bugs again from 13. I've said what I think could be done about this. I think some users, perhaps 85%, will change their postings if guidelines are posted and they find what they considered critical isn't. Ann

4 3

someone make a theme out of these templates
by Adrian Rossouw 10 Mar '06

10 Mar '06

http://www.mollio.org/ please =) -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com

18 24

RE: [development] Re: 18 critical bugs left
by Boerland, Bert 10 Mar '06

10 Mar '06

-----Original Message----- From: development-bounces(a)drupal.org > If there were hundreds of critical bugs, we'd have a problem. For > now, it is fairly easy to review 18 critical bugs and to re- > categorize those that have the wrong priority. that would hold true if you would like at the problem from the "critcical bugs pov". however, how many of the 1000's "normal" bugs would qualify as critical? -- groets bertb

7 6

Huge features limited to early in the release cycle
by Khalid B 09 Mar '06

09 Mar '06

Here is an observation and suggestion. As we all know, the FormsAPI was a REALLY BIG change for 4.7. If I recall correctly, it was relatively late in the release cycle (last fall I think) when it was included. The fact that all forms for core and many contrib modules have to be rewritten is a huge effort. Refactoring parts of it (e.g. _execute to _submit, and many other changes) made the learning curve very steep for module developers. So, in the future, for new features that have a far reach, and scope/magnitude, such as the new theme system proposed by Adrian, and is being discussed in the themes mailing lists, I propose that they be considered only if they are relatively early in the release cycle, so we have time to squash the bugs, get over the learning curve, ..etc. Now, back to getting 4.7 out of the door ...

2 1

Re: [bug] Allow embedded images in project description
by David Reed 09 Mar '06

09 Mar '06

I've updated this issue with a new patch that adds a new "preview_url" field to store a screenshot image url. This patch also provides for using the existing screenshots field to show a "more previews" type link. On 3/6/06, Dries <drupal-devel(a)drupal.org> wrote: > > Issue status update for > http://drupal.org/node/49575 > Post a follow up: > http://drupal.org/project/comments/add/49575 > > Project: Project > Version: cvs > Component: User interface > Category: bug reports > Priority: normal > Assigned to: Anonymous > Reported by: der > Updated by: Dries > Status: patch (code needs review) > > Code comment: we should wrap a check_url() around the screenshot URL > (depending on the format). We should add an alt-attribute for level 1 > accessibility. > > > What happens with projects who configured a screenshot link? The > Drupal project's screenshot link, for example, points to a gallery (see > http://drupal.org/project/drupal) Maybe we need to add a second URL so > we can do stuff like they do at the Firefox plugin directory (see > > https://addons.mozilla.org/extensions/moreinfo.php?id=220&application=firef… > and note the 'more previews' link below the screenshot). > > > Would you be able to work on this some more, so we can implement this > properly? I'd be happy to help test/review such functionality and roll > it out on drupal.org. > > > > > Dries > > > > Previous comments: > ------------------------------------------------------------------------ > > Wed, 15 Feb 2006 21:09:41 +0000 : der > > Per the related discussion [1] on the infrastructure mailing list, there > needs to be a way to embed an image in the description of a project. > This is particularly useful for showing theme screenshots. > [1] > http://lists.drupal.org/archives/infrastructure/2006-02/msg00154.html > > > > > ------------------------------------------------------------------------ > > Sat, 04 Mar 2006 05:35:47 +0000 : der > > Attachment: http://drupal.org/files/issues/project.module_1.patch (1.69KB) > > Here's a patch that uses the existing screenshots db field for the img > tag source. > > > > > ------------------------------------------------------------------------ > > Mon, 06 Mar 2006 15:09:14 +0000 : der > > Just a comment on this patch. The intent of this feature request was to > allow screenshot images to be displayed for "theme" projects. But the > patch doesn't limit it to any particular project type. My assumption > is that it could be controlled in the stylesheet. > > > > >

1 0

Error: Cannot create references to/from string offsets nor overloaded objects
by Karoly Negyesi 09 Mar '06

09 Mar '06

Hi! Form properties, their name beginning with a # , can be of any type. However, if there is no #, it's a child and it must be an array. If it's not, you'll get "Cannot create references to/from string offsets nor overloaded objects". If you get this error, you missed a #. If you an issue filed with this it's very probable that it's a contrib module not yet form API'd or a bogus module. Regards NK

1 0

Updated spellcheck module - now what
by Will Wyatt 09 Mar '06

09 Mar '06

Hi all. I've completly rewritten the old 4.5 spellcheck module. I'm about ready to 'release' the module and wonder what I'm supposed to do now. I could create a patch, but there is almost nothing that remains from the old spellcheck module. This is also my first module for Drupal, so I'm hoping I've done everything correctly. So, what should I do now? The module uses the GPL'ed Speller Pages from http://spellerpages.sourceforge.net and requires aspell on the server. You can try it out at http://test.willwyatt.com you can login as testuser/testuser and create a blog entry. There should be a 'Check Spelling' button below the body form element. The module only works with 4.7 and has only been tested against 4.7 CVS. The module really is just a front end to aspell, so your mileage may vary depending on your aspell installation. Code is available http://www.willwyatt.com/files/spellcheck.tar.gz I guess if the code meets requirements I'd like to be the maintainer of the new module. -- Proud member of the KEXP cubicle army. http://www.cubiclearmy.com

3 3

floating resource
by Urbits - Info 09 Mar '06

09 Mar '06

I am about to do a clean install on my test server (php5). I'm available to test code for the next 2-3 hours. Email me or reply here with links as appropriate.

2 2

crazy request: solidarity
by Dries Buytaert 09 Mar '06

09 Mar '06

I'm the first person to acknowledge that working on Drupal should be fun and that you should work on aspects of the code that you think are particularly interesting or rewarding. However, the current focus is clear: getting Drupal 4.7.0 out. As a result, some of us have dropped all the 'fun Drupal things' to focus solely on getting the Drupal 4.7.0 release out. I, for one, haven't worked on new features for months. At the same time, many people have been working on their pet projects. See, those who are committed to getting Drupal 4.7.0 out want to pick up their pet projects too ... We're getting to a point where solidarity becomes absolutely indispensable and to focus on the greater good: getting Drupal 4.7.0 out. So, the "crazy request" goes like this: 1. Can we stop implementing irrelevant improvements? Can we stop working on our pet projects for a moment? (I'm _not_ talking about important improvements for Drupal 4.8/5.0.) 2. Can we stop discussing things you are not going to start working on the next few days? This is not the time to waste time and resources with discussions that lead no where. The focus is clear. Thanks. -- Dries Buytaert :: http://buytaert.net/

1 0