- Development - lists.drupal.org

Best practices: Config settings
by Gerhard Killesreiter 08 Jan '08

08 Jan '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi there, my question is: Where should contrib module authors put config options for their modules? 1) Should this always be the individual module's settings page? 2) Should it try to add the config option to a more generic place (either provided by core or another module it depends on)? 3) Should it add it to both places? Concrete example: I've added a performance related variable to event module. The value of the variable decides whether to do a full node load for each event on a calendar or to only use title, start, and end date from one mysql query. Now I need to put the UI for this variable somewhere... The variable also has influence on the theme you use since you can't print out any other node content fields if they aren't there. The event functions that event.module ships with for example expect the presence of a teaser field. In principle, I think that the variable should be set at admin/settings/performance but who is going to look there again after each newly installed module? Cheers, Gerhard -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHetFwfg6TFvELooQRAtEXAJ9sU3W05FUyTydSeI85m5XeQRL0RQCeO78A pXSmapndM+S87aiVN3gYed0= =Ood9 -----END PGP SIGNATURE-----

13 16

Re: [development] Using Admin Theme on Other Pages
by Ben Wheeler 08 Jan '08

08 Jan '08

Sorry, I'm reviving this thread from about a week ago. I've been in the process of moving and haven't had a chance to look at it again until tonight. I discovered the problem. I have my custom site module's weight set to 10, because it has to run after other modules (e.g. webfm*) and so I guess it was running after theming. * Specifically, my hook_form_alter has to run after webfm's because I added an extra validation function so that user's are required to attach at least one file using webfm to particular node types. Maybe someone can shed some light on this. Are there any other options for me besides renaming my module z_custom? Am I approaching this the wrong way? Thanks. Ben --------------------------PREVIOUS MESSAGES------------------------------------- Date: Sun, 30 Dec 2007 18:19:36 -0500 From: Doug Green <douggreen(a)douggreenconsulting.com> Subject: Re: [development] Using Admin Theme on Other Pages To: development(a)drupal.org Message-ID: <47782788.2050906(a)douggreenconsulting.com> Content-Type: text/plain; charset=UTF-8 Yes, that's pretty much what I do in the civicrm_theme. http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/civicrm_theme/… function civicrm_theme_menu($may_cache) { if ($may_cache) { } elseif (arg(0) == 'civicrm') { global $custom_theme; $theme_var = arg(1) == 'admin' ? 'civicrm_admin_theme' : 'civicrm_theme'; if (($custom_theme = variable_get($theme_var, '0')) != '0') { $path = drupal_get_path('module', 'system'); drupal_add_css($path .'/admin.css', 'module'); } } return array(); }

2 1

Re: [development] Admin Notes
by Nancy Wichmann 08 Jan '08

08 Jan '08

Actually if you make it an addition to Site Notes, I can close a feature request. Nancy E. Wichmann, PMP

2 1

Admin Notes
by Aaron Winborn 07 Jan '08

07 Jan '08

This module idea (for Admin Notes) is one I've wanted for some time. Before I add this, can folks let me know if something like this already exists? Any comments, ideas, or criticisms? This would be useful for developers, admins & editors to add development notes to individual pages and views, easily visible and accessible directly from a page or menu tree in question. Thanks, Aaron Winborn Advomatic // $Id: README.txt,v 1.1 2008/01/07 21:14:19 aaron Exp $ The Admin Notes module creates a block that displays a comment followed by a form. The form contains a textarea pre-filled with the existing comment. Each comment is associated with a page, and any child pages in that menu tree. Any parent comments will be displayed above the current page comment (if any). For example: on the /articles page: Admin Notes =========== This page is created with a view. It lists all nodes of the article type. ------------------------ + This page is created + + with a view. It + + lists all nodes of + + the article type. + ------------------------ Submit Delete ------------------------------- on the /articles/2008 page: Admin Notes =========== (grayed text, from parent page) (This page is created with a view.) (It lists all nodes of the article type.) This view lists all articles published in 2008. ------------------------ + This view lists all + + articles published + + in 2008. + + + ------------------------ Submit Delete

3 3

gearing up for a Drupal 6 RC2 on monday (Jan 7)
by Gábor Hojtsy 07 Jan '08

07 Jan '08

Hello World, I am planning/preparing to release Drupal 6.0 RC2 on Monday (7th January). Right now, we are at a total of 6 critical issues, two of which are user experience issues (hiding textareas and the teaser splitter), two are database issues (improper indexes were added in RC1, user_save() misbehaves with improper data), and we have a search issue and an update.php memory limit issue. I hope to see even more testers around the patches presented, and eventually have "many" of these fixed by the time RC2 is rolled. I crafted an announcement node for RC2, although it was quite hard to come up with a list of issues fixed since RC1 in human terms, since most of the issues are quite obscure, only occurring under weird circumstances: http://drupal.org/drupal-6.0-rc2 Polishing this up is also appreciated. The shrinking criticals queue also means that we are getting really close to the final release (unless major bugs surface). So if you are module / theme maintainers, feel free to jump on the opportunity to update your contributions. :) Translators will have new templates generated, as RC2 has a (really) small number of string changes, which were necessary to make. As it looks from the criticals queue, fixing some bugs will require more small additions to strings. Gabor

1 1

Biggest usability issues in Drupal?
by Bevan Rudge 07 Jan '08

07 Jan '08

I need help to decide exactly what the goals of the SoU Drupal project will be. I have posted 7 possible different project goals to the SoU group on g.d.o. I am seeking feedback from chx (technical mentor), the drupal developer community and colleagues at CivicActions. http://groups.drupal.org/node/7965 Your input is much appreciated! :) Bevan/ -- Drupal.geek.nz | Gtalk bevan(a)lucion.co.nz | YIM rudgy_m_nz | .Mac/AOL b.rudge | skype b.rudge | Twitter.com/BevanR

1 0

Re: [development] Getting both better internal and external APIs intoDrupal 7
by Michelle Cox 06 Jan '08

06 Jan '08

On 12/31/2007 7:50:22 PM, Khalid Baheyeldin (kb(a)2bits.com) wrote: > I tried my best to have install profiles named something else (packages, > distros), but the counter > argument is that it was too late to do it. > > This will cause a lot of confusion in the future, unless we give profile. > module the bullet of mercy in D6 and replace it with bio (or friends) for > example. It will still be confusing. I think anyone who's familiar with social networking sites will tend to associate "profile" with people, even though it does have other meanings. Michelle

7 6

Drupal 6: Theming system_settings_form() forms
by Juraj Chlebec 05 Jan '08

05 Jan '08

Hi, For example i have code looks like this: <?php ... /** * hook_theme() */ function themedemo_theme() { return array( 'themedemo_example' => array( 'arguments' => array('form' => NULL) ) ); } /** * my admin settings form */ function themedemo_example() { $form = array(); $form['example'] = array( '#title' => t('This is just an example'), '#type' => 'checkbox', '#default_value' => FALSE ); return system_settings_form($form); } /** * The function that has to be registered in hook_theme() */ function theme_themedemo_example($form) { $form['example']['#description'] = t('This description was added by the registered theme function.'); $output = drupal_render($form); return $output; } ?> I think this is legal Drupal form. But in this case my theme function do not work. If i remove return system_settings_form($form); and return $form; only theming function work perfect. Where is problem? Thanks for advance. Havran -- Juraj Chlebec aka Havran http://www.fem.uniag.sk/havran - Havranov mini-blog

2 2

Updating drupal.org to Drupal 6 release candidate
by Gerhard Killesreiter 05 Jan '08

05 Jan '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi there, it is a time honoured tradition that drupal.org is updated to the first release candidate of a new Drupal release as soon as this is available. The first RC of D6 is now available, now when is that update going to happen? The answer is unfortunately: Not very soon. The reason is not the release candidate but the multiple dependencies that drupal.org has. The most well known is probably the project module and it's many friends. However, there are also other dependencies of which I can't find a D6-ready release or some attempt at one (image.module and simplenews for example). Project* has it's own roadmap on the D6 update here: http://groups.drupal.org/node/6180 While I am not entirely happy with the order of the items (I'd obviously prefer to have points 10 and 11 at the top), there is at least something to look at. Also, people who would like to see d.o updated do know how they can help. Unfortunately, there aren't that many people who are eager to help. What I am trying to do is to establish a timeline of when d.o could be updated. So I'd like the maintainers (or other knowledgable parties) to speak up and tell me what their guestimates for updates to D6 are: - - project - - project_issues - - versioncontrol - - views - - image - - image_gallery - - image_attach - - simplenews - - lists - - feature Cheers, Gerhard -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHdpROfg6TFvELooQRAq1UAJ9otQ4pb1veB/DOYFMUnTZjy4tIAgCfWe+w awu0DgZI3+YLejToiw87N6s= =Hexe -----END PGP SIGNATURE-----

10 15

Re: [development] Question on Drupal 6 menus
by Peter Wolanin 05 Jan '08

05 Jan '08

Khalid, One thing looks wrong for sure: 'file' => 'lists.module', I'm not sure if that's causing the problem, but it instructs the menu system to include the module file again. 'file' should only be used with .inc files. Also, don't use t() anywhere - titles, etc are localized dynamically. Finally (and most importantly), the access part is wrong. Since you are using the defaullt callback (user_access), you can have something like this: function lists_menu() { $items = array(); $items['lists'] = array( 'title' => 'Mailing lists', 'page callback' => 'drupal_get_form', 'page arguments' => array('lists_subscribe_form'), 'access arguments' => array('access content'), 'type' => MENU_SUGGESTED_ITEM, ); return $items; } > ---------- Forwarded message ---------- > From: "Khalid Baheyeldin" <kb(a)2bits.com> > To: development(a)drupal.org > Date: Thu, 3 Jan 2008 20:27:37 -0500 > Subject: [development] Question on Drupal 6 menus > This is a question for chx, but I posted it publicly so we all benefit from his reply. > > I found a weird problem with the menus in D6. Most probably I am missing something > obvious, but I am missing what it is. > > This does work. Note that the lists inherits from admin, and it is a NORMAL item. > > function lists_menu() { > $items = array(); > $items['admin/lists'] = array( > 'title' => t('Mailing lists'), > 'page callback' => 'drupal_get_form', > 'page arguments' => array('lists_subscribe'), > 'access' => user_access('access content'), > 'type' => MENU_NORMAL_ITEM, > 'file' => 'lists.module', > ); > return $items; > } > > This, which is what I want, does not show the lists path anywhere, not under menu > as disabled, nothing (I marked the changed lines with an *). > > function lists_menu() { > $items = array(); > * $items['lists'] = array( > 'title' => t('Mailing lists'), > 'page callback' => 'drupal_get_form', > 'page arguments' => array('lists_subscribe'), > 'access' => user_access('access content'), > * 'type' => MENU_SUGGESTED_ITEM, > 'file' => ' lists.module', > ); > return $items; > } > > The latter is the one needed so that the path can be enabled or disabled in the > menus as needed. This is the way it works on D5. > > What is amiss here? > -- > Khalid M. Baheyeldin > 2bits.com, Inc. > http://2bits.com > Drupal optimization, development, customization and consulting. > -- > [ Drupal development list | http://lists.drupal.org/ ] >

3 3