January 2006 - drupal-cvs - lists.drupal.org

[contributions:dado] /modules/tagnode README.txt tagnode.module
by drupal-cvs＠drupal.org 20 Jan '06

20 Jan '06

User: dado Branch: HEAD Date: Fri, 20 Jan 2006 09:27:52 +0000 Modified files: /modules/tagnode README.txt tagnode.module Log message: when user enters new taxonomy term, the corresponding tagnode is created (with only the title populated). This supports freetagging, in which users can enter new terms. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/tagnode/README.tx… http://cvs.drupal.org/diff.php?path=contributions/modules/tagnode/tagnode.m…

1 0

[contributions:romca] /modules/ejournal directory /modules/ejournal - New
by drupal-cvs＠drupal.org 20 Jan '06

20 Jan '06

User: romca Branch: HEAD Date: Fri, 20 Jan 2006 09:25:02 +0000 Added files: /modules/ejournal directory Modified files: /modules/ejournal - New Log message: Directory /cvs/drupal-contrib/contributions/modules/ejournal added to the repository Links: http://cvs.drupal.org/diff.php?path=contributions/modules/ejournal/director… http://cvs.drupal.org/diff.php?path=contributions/modules/ejournal/-&old=&n… http://cvs.drupal.org/diff.php?path=contributions/modules/ejournal/New&old=…

1 0

[drupal:dries] /includes theme.inc
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 09:19:21 +0000 Modified files: /includes theme.inc Log message: - Patch #45451 by wtanaka: added explanation for the red star. Links: http://cvs.drupal.org/diff.php?path=drupal/includes/theme.inc&old=1.277&new…

1 0

[drupal:dries] /includes menu.inc
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 09:12:26 +0000 Modified files: /includes menu.inc Log message: - Patch #40849 by wtanaka and Richard: killed some menu.inc warnings/notices. Links: http://cvs.drupal.org/diff.php?path=drupal/includes/menu.inc&old=1.101&new=…

1 0

[drupal:dries] /misc drupal.css /modules aggregator.module /themes/bluemarine style.css /themes/chameleon common.css /themes/pushbutton style.css
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 09:09:18 +0000 Modified files: /misc drupal.css /modules aggregator.module /themes/bluemarine style.css /themes/chameleon common.css /themes/pushbutton style.css Log message: - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module HTML/CSS cleanups. Links: http://cvs.drupal.org/diff.php?path=drupal/misc/drupal.css&old=1.134&new=1.… http://cvs.drupal.org/diff.php?path=drupal/modules/aggregator.module&old=1.… http://cvs.drupal.org/diff.php?path=drupal/themes/bluemarine/style.css&old=… http://cvs.drupal.org/diff.php?path=drupal/themes/chameleon/common.css&old=… http://cvs.drupal.org/diff.php?path=drupal/themes/pushbutton/style.css&old=…

1 0

[drupal:dries] /modules block.module blog.module book.module comment.module filter.module forum.module node.module page.module story.module user.module
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 09:04:35 +0000 Modified files: /modules block.module blog.module book.module comment.module filter.module forum.module node.module page.module story.module user.module Log message: - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. Links: http://cvs.drupal.org/diff.php?path=drupal/modules/block.module&old=1.196&n… http://cvs.drupal.org/diff.php?path=drupal/modules/blog.module&old=1.241&ne… http://cvs.drupal.org/diff.php?path=drupal/modules/book.module&old=1.341&ne… http://cvs.drupal.org/diff.php?path=drupal/modules/comment.module&old=1.418… http://cvs.drupal.org/diff.php?path=drupal/modules/filter.module&old=1.101&… http://cvs.drupal.org/diff.php?path=drupal/modules/forum.module&old=1.304&n… http://cvs.drupal.org/diff.php?path=drupal/modules/node.module&old=1.589&ne… http://cvs.drupal.org/diff.php?path=drupal/modules/page.module&old=1.150&ne… http://cvs.drupal.org/diff.php?path=drupal/modules/story.module&old=1.182&n… http://cvs.drupal.org/diff.php?path=drupal/modules/user.module&old=1.562&ne…

1 0

[drupal:dries] /modules user.module
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 08:58:09 +0000 Modified files: /modules user.module Log message: - Patch #45312 by Robin and Zen: made theme_user_list() more like theme_item_list(), made it robust for empty lists. Links: http://cvs.drupal.org/diff.php?path=drupal/modules/user.module&old=1.561&ne…

1 0

[drupal:dries] /includes theme.inc /themes/bluemarine page.tpl.php /themes/chameleon chameleon.theme /themes/engines/phptemplate phptemplate.engine /themes/pushbutton page.tpl.php
by drupal-devel＠drupal.org 20 Jan '06

20 Jan '06

User: dries Branch: HEAD Date: Fri, 20 Jan 2006 08:54:07 +0000 Modified files: /includes theme.inc /themes/bluemarine page.tpl.php /themes/chameleon chameleon.theme /themes/engines/phptemplate phptemplate.engine /themes/pushbutton page.tpl.php Log message: - Patch #27884 by gordon: js addLoadEvent not working. Links: http://cvs.drupal.org/diff.php?path=drupal/includes/theme.inc&old=1.276&new… http://cvs.drupal.org/diff.php?path=drupal/themes/bluemarine/page.tpl.php&o… http://cvs.drupal.org/diff.php?path=drupal/themes/chameleon/chameleon.theme… http://cvs.drupal.org/diff.php?path=drupal/themes/engines/phptemplate/phpte… http://cvs.drupal.org/diff.php?path=drupal/themes/pushbutton/page.tpl.php&o…

1 0

[contributions:morbus] /modules/game/races grey.inc vampire.inc /modules/game CHANGELOG.txt TODO.txt /modules/game/races human.inc robot.inc zombie.inc
by drupal-cvs＠drupal.org 20 Jan '06

20 Jan '06

User: morbus Branch: HEAD Date: Fri, 20 Jan 2006 05:05:05 +0000 Added files: /modules/game/races grey.inc vampire.inc Modified files: /modules/game CHANGELOG.txt TODO.txt /modules/game/races human.inc robot.inc zombie.inc Log message: Race tweaks and additions. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/game/races/grey.i… http://cvs.drupal.org/diff.php?path=contributions/modules/game/races/vampir… http://cvs.drupal.org/diff.php?path=contributions/modules/game/CHANGELOG.tx… http://cvs.drupal.org/diff.php?path=contributions/modules/game/TODO.txt&old… http://cvs.drupal.org/diff.php?path=contributions/modules/game/races/human.… http://cvs.drupal.org/diff.php?path=contributions/modules/game/races/robot.… http://cvs.drupal.org/diff.php?path=contributions/modules/game/races/zombie…

1 0

[contributions:weitzman] /modules/og/contrib/og_book og_book.mysql /modules/og/contrib/og_book og_book.module
by drupal-cvs＠drupal.org 20 Jan '06

20 Jan '06

User: weitzman Branch: HEAD Date: Fri, 20 Jan 2006 05:01:11 +0000 Added files: /modules/og/contrib/og_book og_book.mysql Modified files: /modules/og/contrib/og_book og_book.module Log message: almost ready Links: http://cvs.drupal.org/diff.php?path=contributions/modules/og/contrib/og_boo… http://cvs.drupal.org/diff.php?path=contributions/modules/og/contrib/og_boo…

1 0