October 2006 - drupal-cvs - lists.drupal.org

[contributions(DRUPAL-4-7--2):dww] /modules/project project.module /modules/project/release project_release.install project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:31:54 +0000 Modified files: /modules/project project.module /modules/project/release project_release.install project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_25.txt by dww and nedjo (comment 40): - moved all the release-related settings for the browse stuff into project_release.module, where they belong. - renamed the old "project_browse_releases" setting to "project_release_browse_versions" - fixed version filter form to use compatibility taxonomy terms, not the whole complex thing with regexps and creating the ".x" list, caching it, etc. - fixed SQL for the version filter - fixed SQL for browse by date so that it only adds the JOIN on {project_release_nodes} if we didn't already JOIN on that for the version filter. - added a project_release_compatibility_list() method to generate the list of compatbility taxonomy terms for use in various places, and ripped out the problematic project_releases_list() function that was never fully working. - instead of just "Filter by version", we print out "Filter by [vocab]", e.g. "Filter by project release API compatibility" by default, or "Filter by Drupal Core compatibility" on d.o. - changed project_release_use_taxonomy() to just return the tree, so we don't have to get the tree twice all the time. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions:pobster] /modules/tablemanager tablemanager.install tablemanager.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: pobster Branch: HEAD Date: Wed, 25 Oct 2006 07:31:45 +0000 Modified files: /modules/tablemanager tablemanager.install tablemanager.module Log message: Couple of minor fixes Links: http://cvs.drupal.org/diff.php?path=contributions/modules/tablemanager/tabl… http://cvs.drupal.org/diff.php?path=contributions/modules/tablemanager/tabl…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.module /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:24:39 +0000 Modified files: /modules/project project.module /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_24.txt by dww and nedjo (comment 39): browse by category is now basically working: - fixed silly SQL error that was causing the empty categories on /project/Modules/category based on confusion between the release nid (nid) and project nid (pid) in the {project_release_nodes} table. - removed the project_default_tid() method, which wasn't really necessary, was buggy, and was causing additional problems because of JOINs on {project_releases} which no longer exists. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:22:42 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_23.txt by dww (comment 38): - resolved the mysterious form errors when submitting release nodes (we were calling form_set_value() on the file-related form elements, but were using the old form locations, not the new $form['file'] array). - fixed up the automatic setting of release node title in cases where we don't have $edit->project set to the entire project object. also, to be safe, we're using the project uri for the title now, not the project title, since that more closely matches the filename. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:18:33 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_22.txt by dww (comment 37): fixes for validation: - properly prevents you from submitting a duplicate release with the same version as an existing one. this works both without cvs.module installed, and in the nasty N-page form. ;) accomplished by means of a new project_release_exists() method that really works. ;) - we need to check isset($edit->version_major) and friends, not just !$edit->version_major, or we incorrectly flag validation errors if you want to submit a 0.0 release without "dev" or anything in the "extra" field. - added some additional check_plain() when using form_set_value() Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:16:08 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_21.txt by dww (comment 36): - restored a few key links we'll want in the download table - if there are no published releases, /node/N/release now tells you about it, instead of being a totally blank page. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:14:28 +0000 Modified files: /modules/project/release project_release.module project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_20.txt by dww (comment 35): - project_release_update.php now correctly handles the taxonomy stuff, and even customizes the api taxonomy for d.o and pre-populates the terms with the ones we need during the conversion. - renamed an "$edit" to "$is_edit" to be more clear this isn't like the $edit var you ususally see in drupal code. - when editing an existing release, only allow users with 'administer projects' permission to change the API compatibility taxonomy - fixed bug in project_release_taxonomy() where i was calling the wrong function to find the api vocab id. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.inc project.install /modules/project/release project_release.install project_release.module project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:12:02 +0000 Modified files: /modules/project project.inc project.install /modules/project/release project_release.install project_release.module project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_19.txt by dww (comment 34): instead of all this hard-coded "API version" crap, i decided to just make that stuff an automatically-created taxonomy (the "Project release API compatibility" vocabulary). if there are no terms in this vocabulary, it is ignored. however, if taxonomy is enabled, and this vocab has terms, then it appears as another version selector element, instead of the text fields for "API major" and "API minor". also in this commit: - moved the "default download" version selector out of project.inc into project_release.module where it belongs (needs work) - added a project_release_project_download_table() method since creating the $body is too painful via pure hook_nodeapi() in 4.7.x. - further conversion of TRUNK -> HEAD for consistency Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:05:20 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_18.txt by dww (comment 33): better setting of required fields during release node edit (e.g. the file-related junk). Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:04:42 +0000 Modified files: /modules/project/release project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_18.txt by dww (comment 33): better populating of the version_extra field (no need to store the initial '-' in there like we used to). Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0