October 2006 - drupal-cvs - lists.drupal.org

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 07:01:31 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_17.txt by dww (comment 30): provide a more reasonable form during release node edits: - project administrators can change everything (except file md5hash and date) - non-admins can at least view everything - version element fieldset is in its own array within $form - added a _project_release_form_add_text_element() helper to insert similar textfield form elements. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions:martinsfromb] /modules/lmo lmo.info
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: martinsfromb Branch: HEAD Date: Wed, 25 Oct 2006 07:00:26 +0000 Added files: /modules/lmo lmo.info Log message: first commit Links: http://cvs.drupal.org/diff.php?path=contributions/modules/lmo/lmo.info&old=…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.css /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:59:14 +0000 Added files: /modules/project/release project_release.css Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_16.txt by dww (comment 28): better version # validation and UI: - ensure that at least 1 of the version elements is filled in - ensure all elements are numeric (except patch, which we allow as 'x', too). - add a hidden form element to control if we want this validation, so that the cvs_form_alter() case can turn this stuff off when necessary for proper functioning of the N-page form. - make $form['version'] a fieldset for CSS goodness and so we don't have to duplicate the words "version number" for each element - shrink down the size of the boxes to something more reasonable - allow version_extra to be 40 chars on the form - CSS float/clear magic to keep everything on the same line Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.inc /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:56:28 +0000 Modified files: /modules/project project.inc /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_15.txt by dww (comment 27): fix all the release node creation ACL problems: - only allow creation of release nodes if we know the project nid (for real, this time) - lots of cleanup/fixing to project_release_access() - added project_release_access_check() to be shared in a few places, which has knowledge of both project owner, and cvs maintainers (if cvs.module is installed) - the link to "add new release" on the project node conditionally appears using the same code - disabled deletion of release nodes entirely. we'd never want to delete them, only unpublish (or else all hell would break loose for the issue queue for historical issues still pointing at one of those releases). Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:52:21 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_14.txt by dww (comment 26): - to make form_alter() life easier, we now group related elements on the release node form into their own arrays (e.g. $form['version'][], $form['tag'][], $form['file'][], etc). - also, slightly smarter setting of the title so to play more nicely with the form_alter()'ed versions of the release node form... - better checking to make sure we don't try to insert empty strings or non-numeric values into the DB for version form elements (it's better to leave them NULL in these cases). Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.install project_release.module project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:50:21 +0000 Modified files: /modules/project/release project_release.install project_release.module project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_13.txt by dww (comment 25): - renamed all occurances of "super" with "API" to be more reasonable and clear. so, it's now the "API major version", "version_api_major", etc. - we correctly set the "rebuild" flag if the selected tag is a branch Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:45:58 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_12.txt by dww (comment 24): = fixed PROJECT_RELEASE_DEFAULT_VERSION_FORMAT based on new handling of % ! and # = fixes to project_release node form: - form_set_value() mojo to protect ourselves from badness in case cvs_form_alter() is turning us into a funky 2-page form... - grouped body and filter into a 'body_filter' array to match how core usually does it = fixes to project_release_view(): - added a check_plain() on the CVS tag just to be extra paranoid - since we're defining our own hook_view(), node_prepare() isn't called, so we have to use check_markup() ourselves Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.inc /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:41:41 +0000 Modified files: /modules/project project.inc /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_11.txt by dww (comment 21): - only show the 'Add new release' link if the project has releases enabled - fixes to project_release_get_releases(): * only display published release nodes * add an argument to control sort order, so we can display options sorted by version in the issue queue, but list nodes sorted by creation date on the /releases page for a project (for now). Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:37:34 +0000 Modified files: /modules/project/release project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_10.txt by dww (comment 20): set extra to "dev" now that i finalized on the whole #extra thing for handling the '-' delimiters. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 06:36:21 +0000 Modified files: /modules/project/release project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_10.txt by dww (comment 20): - now use !== not != when testing for an empty string, so that a 0 doesn't match. this fixes problems with project_release_get_version() getting confused by version elements set to 0. - in the non-cvs case, we can't really make *everything* in the format string a required variable, since the whole idea is that some of the elements in the format string might not be present. some day, we need a better solution for this. - when viewing a release node, if the rebuild flag is set, we print out that it's a nightly development snapshot, and print out the branch, too. also, i moved the description below the header info about the release, and removed a line of dead code. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0