October 2006 - drupal-cvs - lists.drupal.org

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:47:07 +0000 Modified files: /modules/project/release project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_7.txt by dww (comment 15): update script improvements: - more consistent about the fact that the initial '-' has to be included in the "extra" field, since it's too crazy to attempt to conditionally include the '-' in the format string only if there's a value in %extra... - adds the KEY on rid to the {project_issues} table - makes $nids_by_rid global in all scopes where we use it - adds "version" field to converted release nodes - stores a little more info (the pid (project id)) in the tables it creates to store what happened and any problems it encounters, and adds some more KEYs we might need for fast access - when we find rid values in {project_comments} that don't exist, we set them to 0 Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project_issue issue.inc mail.inc
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:45:31 +0000 Modified files: /modules/project_issue issue.inc mail.inc Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_7.txt by dww (comment 15): ported project_issue.module to the new system. project_release_load() has radically changed into a valid hook_load() implementation, so i had to change all the call-sites in project_issue/issue.inc and project_issue/mail.inc to either use that method correctly or call a different method as appropriate. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project_issue/iss… http://cvs.drupal.org/diff.php?path=contributions/modules/project_issue/mai…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.install project_release.module project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:41:38 +0000 Modified files: /modules/project/release project_release.install project_release.module project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_6.txt by dww (comment 13): big changes to release/project_release_update.php: - adds user output, timing values, and some benchmarking code - populates the {project_release_projects} table correctly, with code to handle d.o special-cases (e.g. documentation project doesn't need releases enabled, core has a different version format string than the site default, etc). - initial support for continuing the conversion if you abort it mid-way - converted to use project_release_get_version() - produces a {project_release_legacy} table that stores the mapping of the old rid to new nid values, along with the times that various parts of the conversion took - added convert_issue_followups() to iterate through all {project_comments} entries that refer to 'rid' in the data field, unserialize, fix up the old values, and updates the DB record. if it fails to map the old values into new nids, it adds a record to {project_comments_conversion_errors} table. - sets a huge php timeout limit also in this commit: - fixed bugs in project_release_alter_project_form() - description of the per-project version string format field now says that if you leave it blank, you get the site default, and prints the current value of the site default. - release info is collapsed by default on project nodes - clean up some whitespace Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release_scan.inc /modules/project project.inc project.module /modules/project/release project_release.install project_release.module project_release_update.php
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:33:59 +0000 Added files: /modules/project/release project_release_scan.inc Modified files: /modules/project project.inc project.module /modules/project/release project_release.install project_release.module project_release_update.php Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_5.txt by dww (comment 11): - added a {project_release_projects} table for release-specific data per project - there's a global setting for the version string format that applies when projects don't define their own in the {project_release_projects} table (called 'project_release_default_version_format'). - removed the version string theme function in favor of project_release_get_version() - added project_release_get_version_format(), which returns the active format string for a given project, either from the project object itself, the {project_release_projects} table, the global admin setting, or a hard-coded default if all else fails. - ended up adding a string-only "version" field to {project_release_nodes} to aid in queries in the rest of the project code that are directly trying to match the full version string with LIKE. - added an initial (still mostly untested and probably buggy) hook_access() so that things start to work for uid != 1. ;) - ripped all the release directory scan stuff out and put it in a separate project_release_scan.inc file (which is currently not being included anywhere). - converted some additional queries to {project_release_nodes} instead of {project_releases} - initial attempt (still unsuccessful) to fix the "Download" link on the project overview pages - fixed bug where file_path UI element was incorrectly being hidden when it wasn't really set, yet. - added a bunch more TODO comments where needed Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release_update.php /modules/project project.install /modules/project/release project_release.install project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:28:44 +0000 Added files: /modules/project/release project_release_update.php Modified files: /modules/project project.install /modules/project/release project_release.install project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_4.txt by dww (comment 9): - add most of an upgrade path for drupal.org (project_release_update.php) and rip out project_update_5() - partially converts to storing all the version fields as NULL when not in use. - adds a "version_patch" column (e.g. for core releases that want to say "4.7.4"). - fixed bug i introduced in last patch where "version_extra" wasn't getting disabled when it should have been. - if a file has already been attached to a project node, the edit tab shouldn't give you a way to attach a different file. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.inc project.install project.module /modules/project/release project_release.install project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:23:08 +0000 Modified files: /modules/project project.inc project.install project.module /modules/project/release project_release.install project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_3.txt by dww (comment 5): - adds a version_extra field to the {project_release_nodes} table and all appropriate places in the code - fixes some help text that was bogus or not showing up right - fixes SQL bugs in project_release_update() - fixes project_update_5() to only create the new tables if they don't already exist - fixes a few places i missed in the conversion from {project_release_node} to {project_release_nodes} Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project CHANGELOG.txt project.install project.module /modules/project/release project_release.install project_release.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:15:54 +0000 Modified files: /modules/project CHANGELOG.txt project.install project.module /modules/project/release project_release.install project_release.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_2.txt by dww (comment 4): - renames {project_release_node} to {project_release_nodes} - adds a CHANGELOG.txt entry ;) Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/CHANGELOG… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project/release project_release.install project_release.module /modules/project release.inc /modules/project project.inc project.install project.module
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:11:50 +0000 Added files: /modules/project/release project_release.install project_release.module Removed files: /modules/project release.inc Modified files: /modules/project project.inc project.install project.module Log message: #83339: make releases real nodes (see also #58066 and #75053) release_as_node.patch_1.txt by dww (comment 1): - moved all release stuff into release/project_release.module - capitalized "Minor version" on the project release node UI for consistency - if there's a conflict in version numbers, we now mark the minor version as the error, since that's the thing users are more likely to want/need to change to avoid the conflict - added the beginnings of project_update_5() to at least create the new {project_release_node} table -- still more to be done. - converted a few more places over to the new schema, and added some // TODO comments in a few others Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/p… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m…

1 0

[contributions:dww] /modules/project/release directory /modules/project/release - New
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: HEAD Date: Wed, 25 Oct 2006 00:08:48 +0000 Added files: /modules/project/release directory Modified files: /modules/project/release - New Log message: Directory /cvs/drupal-contrib/contributions/modules/project/release added to the repository --> Using per-directory sticky tag `DRUPAL-4-7--2' Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/d… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/-… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release/N…

1 0

[contributions(DRUPAL-4-7--2):dww] /modules/project project.inc project.install project.module release.inc
by drupal-cvs＠drupal.org 25 Oct '06

25 Oct '06

User: dww Branch: DRUPAL-4-7--2 Date: Wed, 25 Oct 2006 00:05:03 +0000 Modified files: /modules/project project.inc project.install project.module release.inc Log message: #83339: make releases real nodes, initial release_as_node.patch by merlinofchaos. see also #58066 and #75053. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.i… http://cvs.drupal.org/diff.php?path=contributions/modules/project/project.m… http://cvs.drupal.org/diff.php?path=contributions/modules/project/release.i…

1 0